From: Alejandro Colomar <alx@kernel.org>
Date: Mon, 29 Jan 2024 22:35:43 +0000 (+0100)
Subject: src/login.c: Use localtime_r(3) instead of localtime(3)
X-Git-Tag: 4.15.1~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4827da0a2f67214792aed72f445b5a53ffcb87df;p=thirdparty%2Fshadow.git

src/login.c: Use localtime_r(3) instead of localtime(3)

This silences a CodeQL warning.  We don't care about reentrancy, but
after this patch we don't need to break a long line, so that's a win.

Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/src/login.c b/src/login.c
index 16236de32..a862c6bdb 100644
--- a/src/login.c
+++ b/src/login.c
@@ -1253,10 +1253,11 @@ int main (int argc, char **argv)
 		    && pwd->pw_uid <= (uid_t) getdef_ulong ("LASTLOG_UID_MAX", 0xFFFFFFFFUL)
 		    && (ll.ll_time != 0))
 		{
-			time_t ll_time = ll.ll_time;
+			time_t     ll_time = ll.ll_time;
+			struct tm  tm;
 
-			STRFTIME(ptime, "%a %b %e %H:%M:%S %z %Y",
-			                localtime(&ll_time));
+			localtime_r(&ll_time, &tm);
+			STRFTIME(ptime, "%a %b %e %H:%M:%S %z %Y", &tm);
 			printf (_("Last login: %s on %s"),
 			        ptime, ll.ll_line);
 #ifdef HAVE_LL_HOST		/* __linux__ || SUN4 */