From: Timo Sirainen <tss@iki.fi>
Date: Sat, 1 Jun 2013 14:11:55 +0000 (+0300)
Subject: lib-index: Avoid memcpy()ing data over itself.
X-Git-Tag: 2.2.3~76
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4860b8746b3b7846a9fe65b8c2907ba8aebd422f;p=thirdparty%2Fdovecot%2Fcore.git

lib-index: Avoid memcpy()ing data over itself.
---

diff --git a/src/lib-index/mail-index-transaction-finish.c b/src/lib-index/mail-index-transaction-finish.c
index 7d4c829885..f990d2d236 100644
--- a/src/lib-index/mail-index-transaction-finish.c
+++ b/src/lib-index/mail-index-transaction-finish.c
@@ -293,8 +293,10 @@ static void expunges_convert_to_uids(struct mail_index_transaction *t)
 		expunges[dest].uid =
 			mail_index_transaction_get_uid(t, expunges[src].uid);
 		if (expunges[dest-1].uid != expunges[dest].uid) {
-			memcpy(expunges[dest].guid_128, expunges[src].guid_128,
-			       sizeof(expunges[dest].guid_128));
+			if (dest != src) {
+				memcpy(expunges[dest].guid_128, expunges[src].guid_128,
+				       sizeof(expunges[dest].guid_128));
+			}
 			dest++;
 		}
 	}