From: Cole Robinson <crobinso@redhat.com>
Date: Thu, 5 Dec 2013 20:03:00 +0000 (-0500)
Subject: qemu: hotplug: Fix double free on USB collision
X-Git-Tag: v1.1.3.2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=489185873044c8c206c95185b0e05e52d1c7a4fe;p=thirdparty%2Flibvirt.git

qemu: hotplug: Fix double free on USB collision

If we hit a collision, we free the USB device while it is still part
of our temporary USBDeviceList. When the list is unref'd, the device
is free'd again.

Make the initial device freeing dependent on whether it is present
in the temporary list or not.

(cherry picked from commit 5953a73787b50da56e2ee820a8095ccb09c7a79b)
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index d8507eeca1..96033ac54c 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1501,7 +1501,10 @@ cleanup:
     }
     if (added)
         virUSBDeviceListSteal(driver->activeUsbHostdevs, usb);
-    virUSBDeviceFree(usb);
+    if (list && usb &&
+        !virUSBDeviceListFind(list, usb) &&
+        !virUSBDeviceListFind(driver->activeUsbHostdevs, usb))
+        virUSBDeviceFree(usb);
     virObjectUnref(list);
     VIR_FREE(devstr);
     return ret;