From: Volker Lendecke <vl@samba.org>
Date: Mon, 24 Feb 2025 20:04:32 +0000 (+0100)
Subject: smbd: Avoid a ZERO_STRUCT with an explicit initialization
X-Git-Tag: tevent-0.17.0~16
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=48a19c5fbff3cf43ba43d8940c5b77bc025a99fa;p=thirdparty%2Fsamba.git

smbd: Avoid a ZERO_STRUCT with an explicit initialization

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index 0370a8332cd..3483a413335 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -1783,7 +1783,10 @@ NTSTATUS smbd_dirptr_lanman2_entry(TALLOC_CTX *ctx,
 	uint32_t mode = 0;
 	char *fname = NULL;
 	struct smb_filename *smb_fname = NULL;
-	struct smbd_dirptr_lanman2_state state;
+	struct smbd_dirptr_lanman2_state state = {
+		.conn = conn,
+		.info_level = info_level,
+	};
 	bool ok;
 	uint64_t last_entry_off = 0;
 	NTSTATUS status;
@@ -1792,9 +1795,6 @@ NTSTATUS smbd_dirptr_lanman2_entry(TALLOC_CTX *ctx,
 
 	mangled_names = lp_mangled_names(conn->params);
 
-	ZERO_STRUCT(state);
-	state.conn = conn;
-	state.info_level = info_level;
 	if (mangled_names != MANGLED_NAMES_NO) {
 		state.check_mangled_names = true;
 	}