From: Pavel Begunkov <asml.silence@gmail.com>
Date: Sun, 5 Apr 2020 21:08:52 +0000 (+0300)
Subject: io_uring: fix ctx refcounting in io_submit_sqes()
X-Git-Tag: v5.7-rc1~28^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=48bdd849e967f1c573d2b2bc24308e24a83f39c2;p=thirdparty%2Flinux.git

io_uring: fix ctx refcounting in io_submit_sqes()

If io_get_req() fails, it drops a ref. Then, awhile keeping @submitted
unmodified, io_submit_sqes() breaks the loop and puts @nr - @submitted
refs. For each submitted req a ref is dropped in io_put_req() and
friends. So, for @nr taken refs there will be
(@nr - @submitted + @submitted + 1) dropped.

Remove ctx refcounting from io_get_req(), that at the same time makes
it clearer.

Fixes: 2b85edfc0c90 ("io_uring: batch getting pcpu references")
Cc: stable@vger.kernel.org # v5.6
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 78ae8e8ed5bfa..79bd22289d730 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1342,7 +1342,6 @@ fallback:
 	req = io_get_fallback_req(ctx);
 	if (req)
 		goto got_it;
-	percpu_ref_put(&ctx->refs);
 	return NULL;
 }