From: Phil Sutter <phil@nwl.cc>
Date: Thu, 5 Dec 2019 10:40:26 +0000 (+0100)
Subject: xtables-restore: Avoid access of uninitialized data
X-Git-Tag: v1.8.5~80
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=48be21bf39f9af35d53af0e211cbd50dcfd12d08;p=thirdparty%2Fiptables.git

xtables-restore: Avoid access of uninitialized data

When flushing, 'buffer' is not written to prior to checking its first
byte's value. Therefore it needs to be initialized upon declaration.

Fixes: 09cb517949e69 ("xtables-restore: Improve performance of --noflush operation")
---

diff --git a/iptables/xtables-restore.c b/iptables/xtables-restore.c
index dd907e0b..63cc15ce 100644
--- a/iptables/xtables-restore.c
+++ b/iptables/xtables-restore.c
@@ -281,7 +281,7 @@ void xtables_restore_parse(struct nft_handle *h,
 			   const struct nft_xt_restore_parse *p)
 {
 	struct nft_xt_restore_state state = {};
-	char preload_buffer[PREBUFSIZ] = {}, buffer[10240], *ptr;
+	char preload_buffer[PREBUFSIZ] = {}, buffer[10240] = {}, *ptr;
 
 	if (!h->noflush) {
 		nft_fake_cache(h);