From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Fri, 5 Mar 2021 19:36:31 +0000 (+0100)
Subject: expression: memleak in verdict_expr_parse_udata()
X-Git-Tag: v0.9.9~110
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=490130bdcec8356db165a02b95cb400d53cc2287;p=thirdparty%2Fnftables.git

expression: memleak in verdict_expr_parse_udata()

Remove unnecessary verdict_expr_alloc() invocation.

Fixes: 4ab1e5e60779 ("src: allow use of 'verdict' in typeof definitions")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/expression.c b/src/expression.c
index 8c6beef9..0c5276d1 100644
--- a/src/expression.c
+++ b/src/expression.c
@@ -260,7 +260,7 @@ static int verdict_expr_build_udata(struct nftnl_udata_buf *udbuf,
 
 static struct expr *verdict_expr_parse_udata(const struct nftnl_udata *attr)
 {
-	struct expr *e = verdict_expr_alloc(&internal_location, 0, NULL);
+	struct expr *e;
 
 	e = symbol_expr_alloc(&internal_location, SYMBOL_VALUE, NULL, "verdict");
 	e->len = NFT_REG_SIZE * BITS_PER_BYTE;