From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 6 Jul 2021 12:05:01 +0000 (+0100)
Subject: ksmbd: Fix read on the uninitialized pointer sess
X-Git-Tag: v5.15-rc1~183^2~10^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4951a84f61d6de4ab5aca1d49a6b6ee2ad2d1eec;p=thirdparty%2Fkernel%2Flinux.git

ksmbd: Fix read on the uninitialized pointer sess

There is a error handling case that passes control to label out_err
without pointer sess being assigned a value. The unassigned pointer
may be any garbage value and so the test of rc < 0 && sess maybe
true leading to sess being passed to the call to ksmbd_session_destroy.
Fix this by setting sess to NULL in this corner case.

Addresses-Coverity: ("Uninitialized pointer read")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index d4ef8f55fa4bc..994b95b6b3c2e 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -1615,6 +1615,7 @@ int smb2_sess_setup(struct ksmbd_work *work)
 	} else if ((conn->dialect < SMB30_PROT_ID ||
 		    server_conf.flags & KSMBD_GLOBAL_FLAG_SMB3_MULTICHANNEL) &&
 		   (req->Flags & SMB2_SESSION_REQ_FLAG_BINDING)) {
+		sess = NULL;
 		rc = -EACCES;
 		goto out_err;
 	} else {