From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 17 Aug 2022 23:32:25 +0000 (+1200)
Subject: samba-tool ldapcmp: use ValueError, not Exception
X-Git-Tag: talloc-2.4.0~1162
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4959d07b965b5567f486405c987af8f251ea4c19;p=thirdparty%2Fsamba.git

samba-tool ldapcmp: use ValueError, not Exception

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/netcmd/ldapcmp.py b/python/samba/netcmd/ldapcmp.py
index dddd5a894be..5d1e8fc952e 100644
--- a/python/samba/netcmd/ldapcmp.py
+++ b/python/samba/netcmd/ldapcmp.py
@@ -556,7 +556,7 @@ class LDAPObject(object):
         elif self.con.view == "collision":
             res = d1.diff_1(d2)
         else:
-            raise Exception("Unknown --view option value.")
+            raise ValueError(f"Unknown --view option value: {self.con.view}")
         #
         self.screen_output = res[1]
         other.screen_output = res[1]