From: Ralf Lici Date: Fri, 18 Jul 2025 19:16:56 +0000 (+0200) Subject: improve float collision logging X-Git-Tag: v2.7_alpha3~27 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=495e02e675a1c64ac902428ac82f6b1bfd35ed25;p=thirdparty%2Fopenvpn.git improve float collision logging Extend the log message printed when an instance floats to an address already taken by another instance with the same certificate. The updated message now includes the instance being closed, the reason it's being closed, and the new instance taking over that address. Change-Id: I217cfb319b85fd75a88f7d4d50c374d28771df28 Signed-off-by: Ralf Lici Acked-by: Gert Doering Message-Id: <20250718191702.9451-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32226.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index ead3dd00b..469668633 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3263,7 +3263,11 @@ multi_process_float(struct multi_context *m, struct multi_instance *mi, mroute_addr_print(&mi->real, &gc)); goto done; } - msg(D_MULTI_MEDIUM, "closing instance %s", multi_instance_string(ex_mi, false, &gc)); + + msg(D_MULTI_LOW, "closing instance %s due to float collision with %s " + "using the same certificate", + multi_instance_string(ex_mi, false, &gc), + multi_instance_string(mi, false, &gc)); multi_close_instance(m, ex_mi, false); }