From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Tue, 30 Jul 2019 19:22:10 +0000 (+0200)
Subject: test-execute: skip test_exec_systemcallfilter_system under ASan
X-Git-Tag: v243-rc2~76
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4967da2dbc4870f5af9acbb99453d6f4802fb1d3;p=thirdparty%2Fsystemd.git

test-execute: skip test_exec_systemcallfilter_system under ASan

This particular test case keeps intermittently failing due to crashing
LSan  when running under clang+ASan. Generally, sanitizers don't
like seccomp filters, so the best option here is to just switch this
test off for this scenario.
---

diff --git a/src/test/test-execute.c b/src/test/test-execute.c
index e308d75a56d..435ab39cd25 100644
--- a/src/test/test-execute.c
+++ b/src/test/test-execute.c
@@ -471,7 +471,12 @@ static void test_exec_restrictnamespaces(Manager *m) {
 }
 
 static void test_exec_systemcallfilter_system(Manager *m) {
-#if HAVE_SECCOMP
+/* Skip this particular test case when running under ASan, as
+ * LSan intermittently segfaults when accessing memory right
+ * after the test finishes. Generally, ASan & LSan don't like
+ * the seccomp stuff.
+ */
+#if HAVE_SECCOMP && !HAS_FEATURE_ADDRESS_SANITIZER
         if (!is_seccomp_available()) {
                 log_notice("Seccomp not available, skipping %s", __func__);
                 return;