From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 18 Jan 2016 03:56:16 +0000 (-0500)
Subject: Add explicit cast to amcostestimate call.
X-Git-Tag: REL9_6_BETA1~850
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=49b49506502026a3653bca490c939dc8934afe95;p=thirdparty%2Fpostgresql.git

Add explicit cast to amcostestimate call.

My compiler doesn't complain here, but David Rowley's does ...
---

diff --git a/src/backend/optimizer/path/costsize.c b/src/backend/optimizer/path/costsize.c
index 8fb483aaebd..eaeb17fcd41 100644
--- a/src/backend/optimizer/path/costsize.c
+++ b/src/backend/optimizer/path/costsize.c
@@ -419,9 +419,10 @@ cost_index(IndexPath *path, PlannerInfo *root, double loop_count)
 	 * Call index-access-method-specific code to estimate the processing cost
 	 * for scanning the index, as well as the selectivity of the index (ie,
 	 * the fraction of main-table tuples we will have to retrieve) and its
-	 * correlation to the main-table tuple order.
+	 * correlation to the main-table tuple order.  We need a cast here because
+	 * relation.h uses a weak function type to avoid including amapi.h.
 	 */
-	amcostestimate = index->amcostestimate;		/* cast to proper type */
+	amcostestimate = (amcostestimate_function) index->amcostestimate;
 	amcostestimate(root, path, loop_count,
 				   &indexStartupCost, &indexTotalCost,
 				   &indexSelectivity, &indexCorrelation);