From: Marek Behún Date: Mon, 15 Jul 2024 11:59:12 +0000 (+0200) Subject: firmware: turris-mox-rwtm: Initialize completion before mailbox X-Git-Tag: v6.11-rc1~189^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=49e24c80d3c81c43e2a56101449e1eea32fcf292;p=thirdparty%2Flinux.git firmware: turris-mox-rwtm: Initialize completion before mailbox Initialize the completion before the mailbox channel is requested. Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver") Signed-off-by: Marek Behún Reviewed-by: Andy Shevchenko Signed-off-by: Arnd Bergmann --- diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c index 3f4758e03c818..3e7f186d239a2 100644 --- a/drivers/firmware/turris-mox-rwtm.c +++ b/drivers/firmware/turris-mox-rwtm.c @@ -499,6 +499,7 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, rwtm); mutex_init(&rwtm->busy); + init_completion(&rwtm->cmd_done); rwtm->mbox_client.dev = dev; rwtm->mbox_client.rx_callback = mox_rwtm_rx_callback; @@ -512,8 +513,6 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev) goto remove_files; } - init_completion(&rwtm->cmd_done); - ret = mox_get_board_info(rwtm); if (ret < 0) dev_warn(dev, "Cannot read board information: %i\n", ret);