From: Shannon Nelson Date: Fri, 6 Sep 2024 23:26:17 +0000 (-0700) Subject: ionic: debug line for Tx completion errors X-Git-Tag: v6.12-rc1~232^2~60^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4a0ec34870a2d278373897cf182cbe662d559eb2;p=thirdparty%2Fkernel%2Flinux.git ionic: debug line for Tx completion errors Here's a little debugging aid in case the device starts throwing Tx completion errors. Signed-off-by: Shannon Nelson Signed-off-by: Brett Creeley Link: https://patch.msgid.link/20240906232623.39651-2-brett.creeley@amd.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c index fc79baad45614..ccdc0eefabe40 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c @@ -648,7 +648,14 @@ static void ionic_rx_clean(struct ionic_queue *q, stats = q_to_rx_stats(q); - if (comp->status) { + if (unlikely(comp->status)) { + /* Most likely status==2 and the pkt received was bigger + * than the buffer available: comp->len will show the + * pkt size received that didn't fit the advertised desc.len + */ + dev_dbg(q->dev, "q%d drop comp->status %d comp->len %d desc->len %d\n", + q->index, comp->status, comp->len, q->rxq[q->head_idx].len); + stats->dropped++; return; }