From: Bart Van Assche <bvanassche@acm.org>
Date: Tue, 4 Oct 2011 16:28:42 +0000 (+0000)
Subject: Helgrind and exp-sgcheck, XML error reporting: move the code printing <kind>...<... 
X-Git-Tag: svn/VALGRIND_3_7_0~142
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4a13377cfc269980d0c191c1e838cfc363a7a1de;p=thirdparty%2Fvalgrind.git

Helgrind and exp-sgcheck, XML error reporting: move the code printing <kind>...</kind> out of a switch statement.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@12095
---

diff --git a/exp-sgcheck/pc_common.c b/exp-sgcheck/pc_common.c
index 429579f76f..89846fd0e7 100644
--- a/exp-sgcheck/pc_common.c
+++ b/exp-sgcheck/pc_common.c
@@ -309,6 +309,9 @@ void pc_pp_Error ( Error* err )
    XError *xe = (XError*)VG_(get_error_extra)(err);
    tl_assert(xe);
 
+   if (xml)
+      emit( "  <kind>%s</kind>\n", pc_get_error_name(err));
+
    switch (VG_(get_error_kind)(err)) {
 
    //----------------------------------------------------------
@@ -316,7 +319,6 @@ void pc_pp_Error ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>SorG</kind>\n");
          emit( "  <what>Invalid %s of size %ld</what>\n",
                xe->XE.SorG.sszB < 0 ? "write" : "read",
                Word__abs(xe->XE.SorG.sszB) );
@@ -357,7 +359,6 @@ void pc_pp_Error ( Error* err )
 
          if (xml) {
 
-            emit( "  <kind>Heap</kind>\n");
             emit( "  <what>Invalid %s of size %ld</what>\n",
                   readwrite(xe->XE.Heap.sszB),
                   Word__abs(xe->XE.Heap.sszB) );
@@ -392,7 +393,6 @@ void pc_pp_Error ( Error* err )
 
          if (xml) {
 
-            emit( "  <kind>Heap</kind>\n");
             emit( "  <what>%s %s of size %ld</what>\n",
                   how_invalid,
                   readwrite(xe->XE.Heap.sszB),
@@ -475,7 +475,6 @@ void pc_pp_Error ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>Arith</kind>\n");
          emit( "  <what>Invalid arguments to %s</what>\n",
                xe->XE.Arith.opname );
          VG_(pp_ExeContext)( VG_(get_error_where)(err) );
@@ -561,7 +560,6 @@ void pc_pp_Error ( Error* err )
 
          if (xml) {
 
-            emit( "  <kind>SysParam</kind>\n");
             emit( "  <what>%s%s contains unaddressable byte(s)</what>\n",
                   what, s );
             VG_(pp_ExeContext)( VG_(get_error_where)(err) );
@@ -589,7 +587,6 @@ void pc_pp_Error ( Error* err )
 
          if (xml) {
 
-            emit( "  <kind>SysParam</kind>\n");
             emit( "  <what>%s%s is non-contiguous</what>\n",
                   what, s );
             VG_(pp_ExeContext)( VG_(get_error_where)(err) );
diff --git a/helgrind/hg_errors.c b/helgrind/hg_errors.c
index 41d99e2695..010f5e0bcd 100644
--- a/helgrind/hg_errors.c
+++ b/helgrind/hg_errors.c
@@ -942,6 +942,9 @@ void HG_(pp_Error) ( Error* err )
    XError *xe = (XError*)VG_(get_error_extra)(err);
    tl_assert(xe);
 
+   if (xml)
+      emit( "  <kind>%s</kind>\n", HG_(get_error_name)(err));
+
    switch (VG_(get_error_kind)(err)) {
 
    case XE_Misc: {
@@ -949,7 +952,6 @@ void HG_(pp_Error) ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>Misc</kind>\n");
          emit( "  <xwhat>\n" );
          emit( "    <text>Thread #%d: %s</text>\n",
                (Int)xe->XE.Misc.thr->errmsg_index,
@@ -985,7 +987,6 @@ void HG_(pp_Error) ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>LockOrder</kind>\n");
          emit( "  <xwhat>\n" );
          emit( "    <text>Thread #%d: lock order \"%p before %p\" "
                     "violated</text>\n",
@@ -1050,7 +1051,6 @@ void HG_(pp_Error) ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>PthAPIerror</kind>\n");
          emit( "  <xwhat>\n" );
          emit_no_f_c(
             "    <text>Thread #%d's call to %t failed</text>\n",
@@ -1082,7 +1082,6 @@ void HG_(pp_Error) ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>UnlockBogus</kind>\n");
          emit( "  <xwhat>\n" );
          emit( "    <text>Thread #%d unlocked an invalid "
                     "lock at %p</text>\n",
@@ -1112,7 +1111,6 @@ void HG_(pp_Error) ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>UnlockForeign</kind>\n");
          emit( "  <xwhat>\n" );
          emit( "    <text>Thread #%d unlocked lock at %p "
                     "currently held by thread #%d</text>\n",
@@ -1157,7 +1155,6 @@ void HG_(pp_Error) ( Error* err )
 
       if (xml) {
 
-         emit( "  <kind>UnlockUnlocked</kind>\n");
          emit( "  <xwhat>\n" );
          emit( "    <text>Thread #%d unlocked a "
                     "not-locked lock at %p</text>\n",
@@ -1205,7 +1202,6 @@ void HG_(pp_Error) ( Error* err )
       if (xml) {
 
          /* ------ XML ------ */
-         emit( "  <kind>Race</kind>\n" );
          emit( "  <xwhat>\n" );
          emit( "    <text>Possible data race during %s of size %d "
                     "at %p by thread #%d</text>\n",