From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 19 Dec 2024 03:28:32 +0000 (-0800)
Subject: netdev-genl: avoid empty messages in napi get
X-Git-Tag: v6.13-rc6~9^2~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4a25201aa46ce88e8e31f9ccdec0e4e3dd6bb736;p=thirdparty%2Fkernel%2Flinux.git

netdev-genl: avoid empty messages in napi get

Empty netlink responses from do() are not correct (as opposed to
dump() where not dumping anything is perfectly fine).
We should return an error if the target object does not exist,
in this case if the netdev is down we "hide" the NAPI instances.

Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241219032833.1165433-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
index 2d3ae0cd3ad25..b0772d135efbe 100644
--- a/net/core/netdev-genl.c
+++ b/net/core/netdev-genl.c
@@ -246,8 +246,12 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info)
 	rcu_read_unlock();
 	rtnl_unlock();
 
-	if (err)
+	if (err) {
+		goto err_free_msg;
+	} else if (!rsp->len) {
+		err = -ENOENT;
 		goto err_free_msg;
+	}
 
 	return genlmsg_reply(rsp, info);