From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 15 Oct 2008 09:55:42 +0000 (+0200)
Subject: add comment about monitor flags bug
X-Git-Tag: v0.9.6~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4a3bf753f89422fb57b50517f6193a37df1b02ec;p=thirdparty%2Fiw.git

add comment about monitor flags bug
---

diff --git a/interface.c b/interface.c
index d83a023..e8f3ea1 100644
--- a/interface.c
+++ b/interface.c
@@ -39,6 +39,13 @@ static int parse_mntr_flags(int *_argc, char ***_argv,
 		     flag < NL80211_MNTR_FLAG_MAX; flag++) {
 			if (strcmp(*argv, mntr_flags[flag]) == 0) {
 				ok = 1;
+				/*
+				 * This shouldn't be adding "flag" if that is
+				 * zero, but due to a problem in the kernel's
+				 * nl80211 code (using NLA_NESTED policy) it
+				 * will reject an empty nested attribute but
+				 * not one that contains an invalid attribute
+				 */
 				NLA_PUT_FLAG(flags, flag);
 				break;
 			}