From: Bruce Momjian <bruce@momjian.us>
Date: Mon, 14 Oct 2002 18:11:17 +0000 (+0000)
Subject: Mention that resetting the timeout may be wrong on select retry.
X-Git-Tag: REL7_3~290
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4a513ab07f9676dc4554b5cb20c60e1ed19aa903;p=thirdparty%2Fpostgresql.git

Mention that resetting the timeout may be wrong on select retry.
---

diff --git a/src/interfaces/libpq/fe-misc.c b/src/interfaces/libpq/fe-misc.c
index 32b197bf6b6..7b5a2eeb152 100644
--- a/src/interfaces/libpq/fe-misc.c
+++ b/src/interfaces/libpq/fe-misc.c
@@ -25,7 +25,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.82 2002/10/14 17:33:08 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.83 2002/10/14 18:11:17 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -824,7 +824,12 @@ retry5:
 		{
 			/*
 			 * 	select() may modify timeout argument on some platforms so
-			 *	use copy
+			 *	use copy.
+			 *	XXX Do we really want to do that?  If select() returns
+			 *	the number of seconds remaining, we are resetting
+			 *	the timeout to its original value.  This will yeild
+			 *	incorrect timings when select() is interrupted.
+			 *	bjm 2002-10-14
 			 */
 			tmp_timeout = *timeout;
 			ptmp_timeout = &tmp_timeout;