From: JP Mens Date: Mon, 12 Feb 2018 08:37:37 +0000 (+0100) Subject: Change wording to indicate may not XFR instead of cannot X-Git-Tag: dnsdist-1.3.0~98^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4a76b6a7cdd9ab1b7030eadc65adcf5168a6b887;p=thirdparty%2Fpdns.git Change wording to indicate may not XFR instead of cannot When a client has no permission to AXFR a zone from a server, the following diagnostics are logged: ``` AXFR of domain 'example' denied: client IP 10.0.0.1 has no permission AXFR of domain 'example' failed: 10.0.0.1 cannot request AXFR ``` I feel the word _cannot_ is incorrect and should be _may not_ to indicate permission. --- diff --git a/pdns/tcpreceiver.cc b/pdns/tcpreceiver.cc index 3e4c00e596..49d2b30d87 100644 --- a/pdns/tcpreceiver.cc +++ b/pdns/tcpreceiver.cc @@ -585,7 +585,7 @@ int TCPNameserver::doAXFR(const DNSName &target, shared_ptr q, int ou } if (!canDoAXFR(q)) { - L<getRemote()<<" cannot request AXFR"<getRemote()<<" may not request AXFR"<setRcode(RCode::NotAuth); sendPacket(outpacket,outsock); return 0;