From: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: Mon, 2 Oct 2023 10:08:09 +0000 (+0200)
Subject: ci: pin ast-comments to work around bug, document other bug as submitted
X-Git-Tag: pool-3.2.0~12^2~29
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4aa1b42a169d3ff84cdb8043060ffa98bd1e34ab;p=thirdparty%2Fpsycopg.git

ci: pin ast-comments to work around bug, document other bug as submitted
---

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index c8990a34f..484d60567 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -25,7 +25,10 @@ jobs:
           python-version: "3.10"
 
       - name: install packages to tests
-        run: pip install ./psycopg[dev,test] codespell ast-comments
+        # ast-comments version pinned beause of bug:
+        # https://github.com/t3rn0/ast-comments/issues/21
+        # TODO: unpin when fixed.
+        run: pip install ./psycopg[dev,test] codespell "ast-comments==1.1.0"
 
       - name: Run black
         run: black --check --diff .
diff --git a/tools/async_to_sync.py b/tools/async_to_sync.py
index e0ba22607..782a7fa23 100755
--- a/tools/async_to_sync.py
+++ b/tools/async_to_sync.py
@@ -13,13 +13,13 @@ from argparse import ArgumentParser, Namespace
 
 import ast_comments as ast
 
-# The ast_comment has an import:
+# ast_comment versions 1.1.0, 1.1.1 have an import:
 #
 #   from typing import Dict, List, Tuple, Union
 #
 # which shadows some of the types defined in ast.
 #
-# TODO: report the issue upstream
+# Reported in https://github.com/t3rn0/ast-comments/issues/22
 import ast as ast_orig
 
 ast.Dict = ast_orig.Dict