From: J. Bruce Fields <bfields@redhat.com>
Date: Mon, 8 Mar 2021 15:51:51 +0000 (-0500)
Subject: Revert "nfsd4: remove check_conflicting_opens warning"
X-Git-Tag: v5.12-rc4~34^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4aa5e002034f0701c3335379fd6c22d7f3338cce;p=thirdparty%2Fkernel%2Flinux.git

Revert "nfsd4: remove check_conflicting_opens warning"

This reverts commit 50747dd5e47b "nfsd4: remove check_conflicting_opens
warning", as a prerequisite for reverting 94415b06eb8a, which has a
serious bug.

Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 61552e89bd89d..482e241c96391 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4952,6 +4952,7 @@ static int nfsd4_check_conflicting_opens(struct nfs4_client *clp,
 		writes--;
 	if (fp->fi_fds[O_RDWR])
 		writes--;
+	WARN_ON_ONCE(writes < 0);
 	if (writes > 0)
 		return -EAGAIN;
 	spin_lock(&fp->fi_lock);