From: Alan Modra <amodra@gmail.com>
Date: Sun, 26 Jan 2025 02:42:45 +0000 (+1030)
Subject: loongson buffer overflow
X-Git-Tag: binutils-2_44~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4ab1e3728b29b14b0e5dce787475ddb3cd590a3f;p=thirdparty%2Fbinutils-gdb.git

loongson buffer overflow

bfd_elfNN_loongarch_set_data_segment_info can be called from the target
after_allocation function with a non-ELF hash table.  This is seen in
the ld-elf pr21884 testcase.  Fix the problem by first checking the
hash table type before writing to a loongarch_elf_hash_table field.

(cherry picked from commit 59ba00f21f7d48780e92a9fb66ed4abbedc3bd28)
---

diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index 80d2c445d03..fc1cbbea71a 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -5264,8 +5264,9 @@ void
 bfd_elfNN_loongarch_set_data_segment_info (struct bfd_link_info *info,
 				     int *data_segment_phase)
 {
-  struct loongarch_elf_link_hash_table *htab = loongarch_elf_hash_table (info);
-  htab->data_segment_phase = data_segment_phase;
+  if (is_elf_hash_table (info->hash)
+      && elf_hash_table_id (elf_hash_table (info)) == LARCH_ELF_DATA)
+    loongarch_elf_hash_table (info)->data_segment_phase = data_segment_phase;
 }
 
 /* Implement R_LARCH_ALIGN by deleting excess alignment NOPs.