From: Alfredo Cruz Date: Wed, 22 Mar 2023 22:44:11 +0000 (+0100) Subject: drm/rockchip: vop2: Add error check to devm_regmap_init_mmio X-Git-Tag: v6.4-rc1~162^2~19^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4ab9157c7e02019fa8d8ab98d4f9e67e6a7cfad1;p=thirdparty%2Flinux.git drm/rockchip: vop2: Add error check to devm_regmap_init_mmio devm_regmap_init_mmio() may return an invalid pointer in case of an error. This patch adds the corresponding IS_ERR check to vop2->map. Signed-off-by: Alfredo Cruz Signed-off-by: Heiko Stuebner Link: https://patchwork.freedesktop.org/patch/msgid/20230322224411.15612-1-alfredo.carlon@gmail.com --- diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index fce992c3506f8..38554ca2fc392 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -2679,6 +2679,8 @@ static int vop2_bind(struct device *dev, struct device *master, void *data) vop2->len = resource_size(res); vop2->map = devm_regmap_init_mmio(dev, vop2->regs, &vop2_regmap_config); + if (IS_ERR(vop2->map)) + return PTR_ERR(vop2->map); ret = vop2_win_init(vop2); if (ret)