From: Aurelien DARRAGON <adarragon@haproxy.com>
Date: Mon, 11 Mar 2024 12:49:56 +0000 (+0100)
Subject: BUG/MINOR: hlua: segfault when loading the same filter from different contexts
X-Git-Tag: v3.0-dev6~101
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4aefffc38c08e4bad88330e9c96c455624d6e5af;p=thirdparty%2Fhaproxy.git

BUG/MINOR: hlua: segfault when loading the same filter from different contexts

Trying to register the same lua filter from global and per-thread context
(using 'lua-load' + 'lua-load-per-thread') causes a segmentation fault in
hlua_post_init().

This is due to a simple copy paste error as we try to print the function
name in the error message (like we do when loading the same lua function
from different contexts) instead of the filter name.

This should be backported up to 2.6.
---

diff --git a/src/hlua.c b/src/hlua.c
index b95d024cae..9578923be9 100644
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -13320,7 +13320,7 @@ int hlua_post_init()
 		if ((reg_flt->flt_ref[0] == -1) == (ret < 0)) {
 			ha_alert("Lua filter '%s' is referenced both ins shared Lua context (through lua-load) "
 			         "and per-thread Lua context (through lua-load-per-thread). these two context "
-			         "exclusive.\n", fcn->name);
+			         "exclusive.\n", reg_flt->name);
 			errors++;
 		}
 	}