From: Nick Alcock <nick.alcock@oracle.com>
Date: Mon, 29 Jul 2024 17:02:03 +0000 (+0100)
Subject: libctf: dump: fix small leak
X-Git-Tag: gdb-16-branchpoint~1259
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b04e01284f29a3d0e94fa0e0dd6a11be71c9a65;p=thirdparty%2Fbinutils-gdb.git

libctf: dump: fix small leak

If you asprintf something and then use it only as input to another asprintf,
it helps to free it afterwards.

libctf/
	* ctf-dump.c (ctf_dump_header): Free the flagstr after use.
	(ctf_dump): Make a NULL return slightly clearer.
---

diff --git a/libctf/ctf-dump.c b/libctf/ctf-dump.c
index cd41996084d..a37d4b75d45 100644
--- a/libctf/ctf-dump.c
+++ b/libctf/ctf-dump.c
@@ -349,6 +349,7 @@ ctf_dump_header (ctf_dict_t *fp, ctf_dump_state_t *state)
 
       if (asprintf (&str, "Flags: 0x%x (%s)", fp->ctf_openflags, flagstr) < 0)
 	goto err;
+      free (flagstr);
       ctf_dump_append (state, str);
     }
 
@@ -814,7 +815,7 @@ ctf_dump (ctf_dict_t *fp, ctf_dump_state_t **statep, ctf_sect_names_t sect,
       if (!str)
 	{
 	  ctf_set_errno (fp, ENOMEM);
-	  return str;
+	  return NULL;
 	}
     }