From: Paul Moore <paul@paul-moore.com>
Date: Tue, 5 Dec 2017 22:17:43 +0000 (-0500)
Subject: selinux: skip bounded transition processing if the policy isn't loaded
X-Git-Tag: v4.16-rc1~125^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b14752ec4e0d87126e636384cf37c8dd9df157c;p=thirdparty%2Fkernel%2Flinux.git

selinux: skip bounded transition processing if the policy isn't loaded

We can't do anything reasonable in security_bounded_transition() if we
don't have a policy loaded, and in fact we could run into problems
with some of the code inside expecting a policy.  Fix these problems
like we do many others in security/selinux/ss/services.c by checking
to see if the policy is loaded (ss_initialized) and returning quickly
if it isn't.

Reported-by: syzbot <syzkaller-bugs@googlegroups.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Reviewed-by: James Morris <james.l.morris@oracle.com>
---

diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index d05496deb2295..8900ea5cbabf2 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -867,6 +867,9 @@ int security_bounded_transition(u32 old_sid, u32 new_sid)
 	int index;
 	int rc;
 
+	if (!ss_initialized)
+		return 0;
+
 	read_lock(&policy_rwlock);
 
 	rc = -EINVAL;