From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Sun, 17 Jan 2021 12:08:39 +0000 (+0100)
Subject: BUG/MINOR: peers: Possible appctx pointer dereference.
X-Git-Tag: v2.4-dev6~51
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b1a05fcf81b4343d29aeb86394d44f29d2116a4;p=thirdparty%2Fhaproxy.git

BUG/MINOR: peers: Possible appctx pointer dereference.

This bug may occur when enabling peers traces. It is possible that
peer->appctx is NULL when entering peer_session_release().
---

diff --git a/src/peers.c b/src/peers.c
index e5b1e57141..754d73a8a8 100644
--- a/src/peers.c
+++ b/src/peers.c
@@ -425,7 +425,7 @@ static void peers_trace(enum trace_level level, uint64_t mask,
 			const struct peer *peer = a2;
 			struct peers *peers = NULL;
 
-			if (peer) {
+			if (peer && peer->appctx) {
 				struct stream_interface *si;
 
 				si = peer->appctx->owner;