From: Julia Lawall Date: Sun, 20 Sep 2020 11:26:14 +0000 (+0200) Subject: scsi: target: rd: Drop double zeroing X-Git-Tag: v5.10-rc1~35^2~20 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b217e015b753c83418cc548acf9fac97961e0a3;p=thirdparty%2Fkernel%2Flinux.git scsi: target: rd: Drop double zeroing sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,n,flags; @@ x = - kcalloc + kmalloc_array (n,sizeof(*x),flags) ... sg_init_table(x,n) // Link: https://lore.kernel.org/r/1600601186-7420-3-git-send-email-Julia.Lawall@inria.fr Signed-off-by: Julia Lawall Signed-off-by: Martin K. Petersen --- diff --git a/drivers/target/target_core_rd.c b/drivers/target/target_core_rd.c index 408bd975170b9..bf936bbeccfee 100644 --- a/drivers/target/target_core_rd.c +++ b/drivers/target/target_core_rd.c @@ -131,7 +131,7 @@ static int rd_allocate_sgl_table(struct rd_dev *rd_dev, struct rd_dev_sg_table * if (sg_per_table < total_sg_needed) chain_entry = 1; - sg = kcalloc(sg_per_table + chain_entry, sizeof(*sg), + sg = kmalloc_array(sg_per_table + chain_entry, sizeof(*sg), GFP_KERNEL); if (!sg) return -ENOMEM;