From: Klaus Jensen <k.jensen@samsung.com>
Date: Tue, 11 Apr 2023 18:54:44 +0000 (+0200)
Subject: hw/nvme: fix memory leak in nvme_dsm
X-Git-Tag: v8.0.0-rc4~4^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b32319cdacd99be983e1a74128289ef52c5964e;p=thirdparty%2Fqemu.git

hw/nvme: fix memory leak in nvme_dsm

The iocb (and the allocated memory to hold LBA ranges) leaks if reading
the LBA ranges fails.

Fix this by adding a free and an unref of the iocb.

Reported-by: Coverity (CID 1508281)
Fixes: d7d1474fd85d ("hw/nvme: reimplement dsm to allow cancellation")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 8b7be142091..ac24eeb5ed5 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -2619,6 +2619,9 @@ static uint16_t nvme_dsm(NvmeCtrl *n, NvmeRequest *req)
         status = nvme_h2c(n, (uint8_t *)iocb->range, sizeof(NvmeDsmRange) * nr,
                           req);
         if (status) {
+            g_free(iocb->range);
+            qemu_aio_unref(iocb);
+
             return status;
         }