From: Bertrand Jacquin <jacquinb@amazon.com>
Date: Wed, 13 Dec 2017 01:07:12 +0000 (+0000)
Subject: MINOR: netscaler: remove the use of cip_magic only used once
X-Git-Tag: v1.9-dev1~573
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b4c286bee603572323e72b56faebbe867498a01;p=thirdparty%2Fhaproxy.git

MINOR: netscaler: remove the use of cip_magic only used once
---

diff --git a/src/connection.c b/src/connection.c
index 8637895a35..e0b740ff92 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -702,7 +702,6 @@ int conn_recv_proxy(struct connection *conn, int flag)
 int conn_recv_netscaler_cip(struct connection *conn, int flag)
 {
 	char *line;
-	uint32_t cip_magic;
 	uint32_t cip_len;
 	uint8_t ip_v;
 
@@ -741,13 +740,11 @@ int conn_recv_netscaler_cip(struct connection *conn, int flag)
 		goto missing;
 
 	line = trash.str;
-
-	cip_magic = ntohl(*(uint32_t *)line);
 	cip_len = ntohl(*(uint32_t *)(line+4));
 
 	/* Decode a possible NetScaler Client IP request, fail early if
 	 * it does not match */
-	if (cip_magic != objt_listener(conn->target)->bind_conf->ns_cip_magic)
+	if (ntohl(*(uint32_t *)line) != objt_listener(conn->target)->bind_conf->ns_cip_magic)
 		goto bad_magic;
 
 	/* Fail if buffer length is not large enough to contain