From: Robin Geuze <robing@transip.nl>
Date: Tue, 23 Mar 2021 15:23:35 +0000 (+0100)
Subject: Make sure the unit tests cover one more scenario, tip from mind04
X-Git-Tag: dnsdist-1.6.0-rc1~28^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b74b76a19d4590990866c2e1e9f56dde55bc145;p=thirdparty%2Fpdns.git

Make sure the unit tests cover one more scenario, tip from mind04
---

diff --git a/pdns/test-communicator_hh.cc b/pdns/test-communicator_hh.cc
index 0973b0300b..131da630fc 100644
--- a/pdns/test-communicator_hh.cc
+++ b/pdns/test-communicator_hh.cc
@@ -69,6 +69,7 @@ BOOST_AUTO_TEST_CASE(test_axfr_queue_insert_and_priority_order_after_modify) {
     {DNSName("test5.com"),ComboAddress("0.0.0.0"),false,{SuckRequest::PdnsControl,3}},
   };
   SuckRequest rr = {DNSName("test3.com"),ComboAddress("0.0.0.0"),false,{SuckRequest::PdnsControl,5}};
+  SuckRequest rr2 = {DNSName("test4.com"),ComboAddress("0.0.0.0"),false,{SuckRequest::Api,6}};
 
   UniQueue suckDomains;
 
@@ -86,6 +87,14 @@ BOOST_AUTO_TEST_CASE(test_axfr_queue_insert_and_priority_order_after_modify) {
     }
   });
 
+  res = suckDomains.insert(rr2);
+  BOOST_CHECK(!res.second);
+  suckDomains.modify(res.first, [priorityAndOrder = rr2.priorityAndOrder] (SuckRequest& so) {
+    if (priorityAndOrder.first < so.priorityAndOrder.first) {
+      so.priorityAndOrder = priorityAndOrder;
+    }
+  });
+
   for (int i = 4; i >= 0; i--) {
     auto iter = suckDomains.begin();
     BOOST_CHECK_EQUAL(iter->domain, sr[i].domain);