From: Taehee Yoo Date: Fri, 28 Feb 2020 18:01:46 +0000 (+0000) Subject: hsr: use netdev_err() instead of WARN_ONCE() X-Git-Tag: v5.7-rc1~146^2~283^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4b793acdca0050739b99ace6a8b9e7f717f57c6b;p=thirdparty%2Flinux.git hsr: use netdev_err() instead of WARN_ONCE() When HSR interface is sending a frame, it finds a node with the destination ethernet address from the list. If there is no node, it calls WARN_ONCE(). But, using WARN_ONCE() for this situation is a little bit overdoing. So, in this patch, the netdev_err() is used instead. Signed-off-by: Taehee Yoo Signed-off-by: David S. Miller --- diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index 3ba7f61be1078..d46d22c7105c2 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -318,7 +318,8 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, node_dst = find_node_by_addr_A(&port->hsr->node_db, eth_hdr(skb)->h_dest); if (!node_dst) { - WARN_ONCE(1, "%s: Unknown node\n", __func__); + if (net_ratelimit()) + netdev_err(skb->dev, "%s: Unknown node\n", __func__); return; } if (port->type != node_dst->addr_B_port)