From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Mon, 27 Feb 2023 16:31:55 +0000 (+0100)
Subject: MINOR: quic: consider EBADF as critical on send()
X-Git-Tag: v2.8-dev5~79
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4bdd0696373b5a683cfab905c65c5af103855bd3;p=thirdparty%2Fhaproxy.git

MINOR: quic: consider EBADF as critical on send()

EBADF on sendto() is considered as a fatal error. As such, it is removed
from the list of the transient errors. The connection will be killed
when encountered.

For the record, EBADF can be encountered on process termination with the
listener socket.

This should be backported up to 2.7.
---

diff --git a/src/quic_sock.c b/src/quic_sock.c
index 95f771135e..77a2a89f55 100644
--- a/src/quic_sock.c
+++ b/src/quic_sock.c
@@ -619,7 +619,7 @@ int qc_snd_buf(struct quic_conn *qc, const struct buffer *buf, size_t sz,
 		                     &quic_stats_module);
 
 		if (errno == EAGAIN || errno == EWOULDBLOCK ||
-		    errno == ENOTCONN || errno == EINPROGRESS || errno == EBADF) {
+		    errno == ENOTCONN || errno == EINPROGRESS) {
 			if (errno == EAGAIN || errno == EWOULDBLOCK)
 				HA_ATOMIC_INC(&prx_counters->socket_full);
 			else