From: Stephan Bosch <stephan.bosch@dovecot.fi>
Date: Sat, 29 Sep 2018 19:09:57 +0000 (+0200)
Subject: lib-smtp: client: transaction: Annotate sub-parts of smtp_client_transaction_fail_rep... 
X-Git-Tag: 2.3.9~1262
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4bee7b2225ee791f9a4135b4f33249b7126dbb87;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: client: transaction: Annotate sub-parts of smtp_client_transaction_fail_reply() with comments.
---

diff --git a/src/lib-smtp/smtp-client-transaction.c b/src/lib-smtp/smtp-client-transaction.c
index 0528044977..cadd3417d6 100644
--- a/src/lib-smtp/smtp-client-transaction.c
+++ b/src/lib-smtp/smtp-client-transaction.c
@@ -331,6 +331,8 @@ void smtp_client_transaction_fail_reply(struct smtp_client_transaction *trans,
 	trans->cmd_last = NULL;
 
 	timeout_remove(&trans->to_send);
+
+	/* MAIL */
 	if (trans->cmd_mail_from != NULL) {
 		smtp_client_command_abort(&trans->cmd_mail_from);
 		if (trans->mail_from_callback != NULL) {
@@ -344,6 +346,7 @@ void smtp_client_transaction_fail_reply(struct smtp_client_transaction *trans,
 		}
 	}
 
+	/* RCPT */
 	rcpts = array_get_modifiable(&trans->rcpts_pending, &count);
 	for (i = 0; i < count; i++) {
 		struct smtp_client_command *cmd = rcpts[i]->cmd_rcpt_to;
@@ -365,6 +368,7 @@ void smtp_client_transaction_fail_reply(struct smtp_client_transaction *trans,
 		}
 	}
 
+	/* DATA */
 	if (!trans->data_provided) {
 		/* smtp_client_transaction_send() was not called yet
 		 */
@@ -388,6 +392,7 @@ void smtp_client_transaction_fail_reply(struct smtp_client_transaction *trans,
 		trans->data_callback = NULL;
 	}
 
+	/* plug */
 	if (trans->failure == NULL)
 		trans->failure = smtp_reply_clone(trans->pool, reply);
 	if (trans->cmd_plug != NULL &&