From: John Baldwin <jhb@FreeBSD.org>
Date: Sat, 11 Jun 2016 20:10:48 +0000 (-0700)
Subject: Remove unneeded checks on type lengths.
X-Git-Tag: users/hjl/linux/release/2.26.51.0.2~1^2~16^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4bf5402d913e9a5d17d9ffb8701dbd054e1d158c;p=thirdparty%2Fbinutils-gdb.git

Remove unneeded checks on type lengths.

Type lengths are unsigned, so they are always greater than or equal to
zero.  A check against the length of 'tgt_type' is retained to prevent
dividing by zero.

gdb/ChangeLog:

	* v850-tdep.c (v850_use_struct_convention): Trim type length checks.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f2db9e9662e..9e57431cc52 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2016-06-14  John Baldwin  <jhb@FreeBSD.org>
+
+	* v850-tdep.c (v850_use_struct_convention): Trim type length checks.
+
 2016-06-14  John Baldwin  <jhb@FreeBSD.org>
 
 	* tui/tui-stack.c (tui_show_frame_info): Fix type mismatch.
diff --git a/gdb/v850-tdep.c b/gdb/v850-tdep.c
index 612eec33fa8..0b50580f7c2 100644
--- a/gdb/v850-tdep.c
+++ b/gdb/v850-tdep.c
@@ -559,7 +559,7 @@ v850_use_struct_convention (struct gdbarch *gdbarch, struct type *type)
 	  if (TYPE_CODE (fld_type) == TYPE_CODE_ARRAY)
 	    {
 	      tgt_type = TYPE_TARGET_TYPE (fld_type);
-	      if (TYPE_LENGTH (fld_type) >= 0 && TYPE_LENGTH (tgt_type) >= 0
+	      if (TYPE_LENGTH (tgt_type) > 0
 		  && TYPE_LENGTH (fld_type) / TYPE_LENGTH (tgt_type) > 2)
 		return 1;
 	    }