From: Leo-Andres Hofmann <hofmann@leo-andres.de>
Date: Wed, 6 Apr 2022 13:46:52 +0000 (+0200)
Subject: getrrdimage.cgi: Add default values to parameters
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4c04960ba0603ff64bd70198e0022948a6df1f62;p=people%2Fms%2Fipfire-2.x.git

getrrdimage.cgi: Add default values to parameters

Prevents "use of uninitialized value" warnings when the
CGI is called with broken undefined GET parameters.

Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
---

diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
index 26e026bba9..6ec91cc926 100644
--- a/html/cgi-bin/getrrdimage.cgi
+++ b/html/cgi-bin/getrrdimage.cgi
@@ -44,9 +44,9 @@ my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi",
 my $uri = URI->new($ENV{'REQUEST_URI'});
 my %query = $uri->query_form;
 
-my $origin = lc $query{'origin'}; # lower case
-my $graph = $query{'graph'};
-my $range = lc $query{'range'}; # lower case
+my $origin = lc ($query{'origin'} // ''); # lower case
+my $graph = $query{'graph'} // '';
+my $range = lc ($query{'range'} // ''); # lower case
 
 # Check parameters
 unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {