From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 15 Jun 2017 08:24:58 +0000 (+0200)
Subject: check the return value of qemuBuildVirtioOptionsStr
X-Git-Tag: v3.5.0-rc1~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4c39f91dde94402a02c2b30aca2af4358c9c7860;p=thirdparty%2Flibvirt.git

check the return value of qemuBuildVirtioOptionsStr

Only qemuBuildFSDevStr missed the return check.
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 900239f056..57893cfdac 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2527,7 +2527,8 @@ qemuBuildFSDevStr(const virDomainDef *def,
                       QEMU_FSDEV_HOST_PREFIX, fs->info.alias);
     virBufferAsprintf(&opt, ",mount_tag=%s", fs->dst);
 
-    qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps);
+    if (qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps) < 0)
+        goto error;
 
     if (qemuBuildDeviceAddressStr(&opt, def, &fs->info, qemuCaps) < 0)
         goto error;