From: Colin Ian King <colin.i.king@gmail.com>
Date: Tue, 9 Sep 2025 19:03:56 +0000 (+0100)
Subject: gpio: loongson-64bit: Fix a less than zero check on an unsigned int struct field
X-Git-Tag: v6.18-rc1~168^2~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4c91b0ee35db07ae017dce067c64364c7e95faae;p=thirdparty%2Fkernel%2Fstable.git

gpio: loongson-64bit: Fix a less than zero check on an unsigned int struct field

Currently the error check from the call to platform_get_irq is always
false because an unsigned int chip->irq.parents[i] is being used to
to perform the less than zero error check. Fix this by using the int
variable ret to perform the check.

Fixes: 03c146cb6cd1 ("gpio: loongson-64bit: Add support for Loongson-2K0300 SoC")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Reviewed-by: Yao Zi <ziyao@disroot.org>
Link: https://lore.kernel.org/r/20250909190356.870000-1-colin.i.king@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---

diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
index 5f87ce5c86cf1..2120e908c634e 100644
--- a/drivers/gpio/gpio-loongson-64bit.c
+++ b/drivers/gpio/gpio-loongson-64bit.c
@@ -267,10 +267,13 @@ static int loongson_gpio_init_irqchip(struct platform_device *pdev,
 		return -ENOMEM;
 
 	for (i = 0; i < data->intr_num; i++) {
-		chip->irq.parents[i] = platform_get_irq(pdev, i);
-		if (chip->irq.parents[i] < 0)
-			return dev_err_probe(&pdev->dev, chip->irq.parents[i],
+		int ret;
+
+		ret = platform_get_irq(pdev, i);
+		if (ret < 0)
+			return dev_err_probe(&pdev->dev, ret,
 					     "failed to get IRQ %d\n", i);
+		chip->irq.parents[i] = ret;
 	}
 
 	for (i = 0; i < data->intr_num; i++) {