From: Tom de Vries Date: Thu, 11 Sep 2025 16:31:37 +0000 (+0200) Subject: [gdb/testsuite, tclint] Fix unrecognized argument in gdb.trace/mi-traceframe-changed.exp X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4c99cc54233d97d712c4a78810ba0ff0850ec3f8;p=thirdparty%2Fbinutils-gdb.git [gdb/testsuite, tclint] Fix unrecognized argument in gdb.trace/mi-traceframe-changed.exp When running tclint on gdb.trace/mi-traceframe-changed.exp, I get: ... $ tclint gdb.trace/mi-traceframe-changed.exp $exp:94:1: unrecognized argument for append: -1 [command-args] $exp:95:1: unrecognized argument for append: -1 [command-args] ... for these lines: ... 94 append testfile -1 95 append binfile -1 ... This seems harmless to me, but since tclint complains, fix this by quoting the -1 arguments. Tested by rerunning tclint. Approved-By: Simon Marchi PR testsuite/33403 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33403 --- diff --git a/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp b/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp index c34f117e4d5..90a053c9315 100644 --- a/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp +++ b/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp @@ -91,8 +91,8 @@ if [generate_tracefile $binfile] { # Change to a different test case in order to run it on target, and get # several traceframes. standard_testfile status-stop.c -append testfile -1 -append binfile -1 +append testfile "-1" +append binfile "-1" set executable $testfile if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \