From: Alexey <bigalex934@gmail.com>
Date: Mon, 29 Jan 2024 19:47:41 +0000 (+0000)
Subject: Fix memory leak in ssl/gadgets/mimicAuthorityKeyId() (#1651)
X-Git-Tag: SQUID_7_0_1~230
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4ca3b58790deff003e223957f5375ddd236b1093;p=thirdparty%2Fsquid.git

Fix memory leak in ssl/gadgets/mimicAuthorityKeyId() (#1651)

An unnecessary std::unique_ptr::release() call prevented temporary
extOct string from being automatically deallocated. The leak usually
happened when SslBump mimicked certificates with an Authority Key
Identifier extension. The leak was added in 2016 commit 5f1318b.
---

diff --git a/src/ssl/gadgets.cc b/src/ssl/gadgets.cc
index 0d6c6f1838..1f8ac9d76d 100644
--- a/src/ssl/gadgets.cc
+++ b/src/ssl/gadgets.cc
@@ -376,7 +376,6 @@ mimicAuthorityKeyId(Security::CertPointer &cert, Security::CertPointer const &mi
     if (!extAuthKeyId.get())
         return false;
 
-    extOct.release();
     if (!X509_add_ext(cert.get(), extAuthKeyId.get(), -1))
         return false;