From: Raymond Hettinger <rhettinger@users.noreply.github.com>
Date: Fri, 24 Apr 2020 09:33:07 +0000 (-0700)
Subject: Expand the implementation comments (GH-19699)
X-Git-Tag: v3.9.0a6~22
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4cc4d6048efcec43fe866fac96e0c2e57a87b308;p=thirdparty%2FPython%2Fcpython.git

Expand the implementation comments (GH-19699)
---

diff --git a/Lib/collections/__init__.py b/Lib/collections/__init__.py
index bb9a605a994f..c4bff592dc0e 100644
--- a/Lib/collections/__init__.py
+++ b/Lib/collections/__init__.py
@@ -711,6 +711,13 @@ class Counter(dict):
     #
     # To strip negative and zero counts, add-in an empty counter:
     #       c += Counter()
+    #
+    # Rich comparison operators for multiset subset and superset tests
+    # are deliberately omitted due to semantic conflicts with the
+    # existing inherited dict equality method.  Subset and superset
+    # semantics ignore zero counts and require that p≤q ∧ p≥q → p=q;
+    # however, that would not be the case for p=Counter(a=1, b=0)
+    # and q=Counter(a=1) where the dictionaries are not equal.
 
     def __add__(self, other):
         '''Add counts from two counters.