From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Mon, 6 Nov 2023 17:05:03 +0000 (+0100)
Subject: MINOR: quic: Avoid zeroing frame structures
X-Git-Tag: v2.9-dev10~125
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4cf784f38ed20b42f6e71bd8a2e8157b95329ee5;p=thirdparty%2Fhaproxy.git

MINOR: quic: Avoid zeroing frame structures

Do not initialize anymore ->type of quic_frame structures which leads
to the others to be zeroed.
---

diff --git a/src/quic_tx.c b/src/quic_tx.c
index b8de12a571..5d343600d5 100644
--- a/src/quic_tx.c
+++ b/src/quic_tx.c
@@ -2185,9 +2185,9 @@ static int qc_do_build_pkt(unsigned char *pos, const unsigned char *end,
 {
 	unsigned char *beg, *payload;
 	size_t len, len_sz, len_frms, padding_len;
-	struct quic_frame frm = { .type = QUIC_FT_CRYPTO, };
-	struct quic_frame ack_frm = { .type = QUIC_FT_ACK, };
-	struct quic_frame cc_frm = { };
+	struct quic_frame frm;
+	struct quic_frame ack_frm;
+	struct quic_frame cc_frm;
 	size_t ack_frm_len, head_len;
 	int64_t rx_largest_acked_pn;
 	int add_ping_frm;
@@ -2245,6 +2245,7 @@ static int qc_do_build_pkt(unsigned char *pos, const unsigned char *end,
 	if ((must_ack || (qel->pktns->flags & QUIC_FL_PKTNS_ACK_REQUIRED)) && !qel->pktns->tx.pto_probe) {
 		struct quic_arngs *arngs = &qel->pktns->rx.arngs;
 		BUG_ON(eb_is_empty(&qel->pktns->rx.arngs.root));
+		ack_frm.type = QUIC_FT_ACK;
 		ack_frm.tx_ack.arngs = arngs;
 		if (qel->pktns->flags & QUIC_FL_PKTNS_NEW_LARGEST_PN) {
 			qel->pktns->tx.ack_delay =