From: Christopher Faulet <cfaulet@haproxy.com>
Date: Tue, 27 Sep 2022 07:14:47 +0000 (+0200)
Subject: BUG/MINOR: stream: Perform errors handling in right order in stream_new()
X-Git-Tag: v2.7-dev7~30
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4cfc038cb19996f5d2fe60284fdb556503a5f9ef;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stream: Perform errors handling in right order in stream_new()

The frontend SC is attached before the backend one is allocated. Thus an
allocation error on backend SC must be handled before an error on the
frontend SC.

This patch must be backported to 2.6.
---

diff --git a/src/stream.c b/src/stream.c
index 8c7cdca796..405992f8b7 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -568,9 +568,9 @@ struct stream *stream_new(struct session *sess, struct stconn *sc, struct buffer
  out_fail_accept:
 	flt_stream_release(s, 0);
 	LIST_DELETE(&s->list);
- out_fail_attach_scf:
-	sc_free(s->scb);
  out_fail_alloc_scb:
+	sc_free(s->scb);
+ out_fail_attach_scf:
 	task_destroy(t);
  out_fail_alloc:
 	pool_free(pool_head_stream, s);