From: Jay Satiro Date: Sun, 9 Feb 2020 08:15:13 +0000 (-0500) Subject: multi: fix outdated comment X-Git-Tag: curl-7_69_0~121 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4d1aa8d43b1983e5930e461b4ed1b305004395f7;p=thirdparty%2Fcurl.git multi: fix outdated comment - Do not say that conn->data is "cleared" by multi_done(). If the connection is in use then multi_done assigns another easy handle still using the connection to conn->data, therefore in that case it is not cleared. Closes https://github.com/curl/curl/pull/4901 --- diff --git a/lib/multi.c b/lib/multi.c index 6c9d06b0b5..37a37a4f0c 100644 --- a/lib/multi.c +++ b/lib/multi.c @@ -730,8 +730,8 @@ CURLMcode curl_multi_remove_handle(struct Curl_multi *multi, we don't leave a half-baked one around */ if(easy_owns_conn) { - /* multi_done() clears the conn->data field to lose the association - between the easy handle and the connection + /* multi_done() clears the association between the easy handle and the + connection. Note that this ignores the return code simply because there's nothing really useful to do with it anyway! */