From: Andrew Goodbody Date: Mon, 11 Aug 2025 16:25:17 +0000 (+0100) Subject: serial: lpuart: Return value from correct variable X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4d3183723f34d58cb5decec77e8bf64b84d309d1;p=thirdparty%2Fu-boot.git serial: lpuart: Return value from correct variable In get_lpuart_clk_rate if the call to clk_get_rate returns an error then the call to return should pass the value of the error which is in rate rather than ret which will be 0 as its value is not affected by this error. This issue was found by Smatch. Signed-off-by: Andrew Goodbody Signed-off-by: Peng Fan --- diff --git a/drivers/serial/serial_lpuart.c b/drivers/serial/serial_lpuart.c index 93602797b83..9fdb6503085 100644 --- a/drivers/serial/serial_lpuart.c +++ b/drivers/serial/serial_lpuart.c @@ -129,7 +129,7 @@ static int get_lpuart_clk_rate(struct udevice *dev, u32 *clk_rate) rate = clk_get_rate(&clk); if ((long)rate <= 0) { dev_err(dev, "Failed to get clk rate: %ld\n", (long)rate); - return ret; + return rate; } *clk_rate = rate; return 0;