From: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
Date: Thu, 16 Nov 2017 02:28:32 +0000 (+0800)
Subject: colo-compare: fix the dangerous assignment
X-Git-Tag: v2.11.0-rc2~14^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4d366235208e58a7bc854b893a671d4b2d9c7a94;p=thirdparty%2Fqemu.git

colo-compare: fix the dangerous assignment

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Zhang Chen <zhangckid@gmail.com>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Fixes: 8ec14402029d783720f4312ed8a925548e1dad61
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---

diff --git a/net/colo-compare.c b/net/colo-compare.c
index ccdcba26911..1ce195f877c 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -179,7 +179,7 @@ static int packet_enqueue(CompareState *s, int mode, Connection **con)
                          "drop packet");
         }
     }
-    con = &conn;
+    *con = conn;
 
     return 0;
 }