From: Luis de Bethencourt <luisbg@osg.samsung.com>
Date: Tue, 21 Jun 2016 05:56:25 +0000 (+1000)
Subject: xfs: remove impossible condition
X-Git-Tag: v4.7.0-rc1~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4d4a192cae6d464368fbb5d95b085ee3be0b4f39;p=thirdparty%2Fxfsprogs-dev.git

xfs: remove impossible condition

Source kernel commit a5fd276bdc4fb71b06d100a6abc77ad682f77de4

bp_release is set to 0 just before the breakpoint of the for loop before
the conditional check (in line 458). The other breakpoint is a goto that
skips the dead code.

Addresses-Coverity-Id: 102338

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

difflibxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index ef00156..9054c50 100644
---

diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c
index c513e4568..ec74ed876 100644
--- a/libxfs/xfs_bmap.c
+++ b/libxfs/xfs_bmap.c
@@ -469,10 +469,7 @@ xfs_bmap_check_leaf_extents(
 		}
 		block = XFS_BUF_TO_BLOCK(bp);
 	}
-	if (bp_release) {
-		bp_release = 0;
-		xfs_trans_brelse(NULL, bp);
-	}
+
 	return;
 
 error0: