From: Greg Kroah-Hartman Date: Thu, 18 Nov 2010 19:21:04 +0000 (-0800) Subject: Staging: samsung-laptop: fix up my fixup for some sysfs attribute permissions X-Git-Tag: v2.6.37-rc5~28^2~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4d7bc388b44e42a1feafa35e50eef4f24d6ca59d;p=thirdparty%2Fkernel%2Flinux.git Staging: samsung-laptop: fix up my fixup for some sysfs attribute permissions They should be writable by root, not readable. Doh, stupid me with the wrong flags. Reported-by: Jonathan Cameron Cc: stable Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c b/drivers/staging/samsung-laptop/samsung-laptop.c index 28700b4982737..ac2bf11e11199 100644 --- a/drivers/staging/samsung-laptop/samsung-laptop.c +++ b/drivers/staging/samsung-laptop/samsung-laptop.c @@ -356,7 +356,7 @@ static ssize_t set_silent_state(struct device *dev, } return count; } -static DEVICE_ATTR(silent, S_IRUSR | S_IRUGO, +static DEVICE_ATTR(silent, S_IWUSR | S_IRUGO, get_silent_state, set_silent_state);