From: Tyler Hicks Date: Thu, 13 Sep 2012 01:38:00 +0000 (-0700) Subject: eCryptfs: Call lower ->flush() from ecryptfs_flush() X-Git-Tag: v3.2.32~23 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4dcbf47bac95e0b7cb4e6fa5347318117a19b580;p=people%2Fms%2Flinux.git eCryptfs: Call lower ->flush() from ecryptfs_flush() commit 64e6651dcc10e9d2cc6230208a8e6c2cfd19ae18 upstream. Since eCryptfs only calls fput() on the lower file in ecryptfs_release(), eCryptfs should call the lower filesystem's ->flush() from ecryptfs_flush(). If the lower filesystem implements ->flush(), then eCryptfs should try to flush out any dirty pages prior to calling the lower ->flush(). If the lower filesystem does not implement ->flush(), then eCryptfs has no need to do anything in ecryptfs_flush() since dirty pages are now written out to the lower filesystem in ecryptfs_release(). Signed-off-by: Tyler Hicks Signed-off-by: Ben Hutchings --- diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index 0747a43e0c17..841f24f2ca84 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs/file.c @@ -276,8 +276,14 @@ out: static int ecryptfs_flush(struct file *file, fl_owner_t td) { - return file->f_mode & FMODE_WRITE - ? filemap_write_and_wait(file->f_mapping) : 0; + struct file *lower_file = ecryptfs_file_to_lower(file); + + if (lower_file->f_op && lower_file->f_op->flush) { + filemap_write_and_wait(file->f_mapping); + return lower_file->f_op->flush(lower_file, td); + } + + return 0; } static int ecryptfs_release(struct inode *inode, struct file *file)