From: zhouchuangao Date: Tue, 30 Mar 2021 12:46:01 +0000 (-0700) Subject: scsi: message: fusion: Use BUG_ON instead of if condition followed by BUG X-Git-Tag: v5.13-rc1~103^2~96 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4dec8004de296952b4afc66b47f50cbf4f8421a9;p=thirdparty%2Flinux.git scsi: message: fusion: Use BUG_ON instead of if condition followed by BUG BUG_ON() uses unlikely in if() which can be optimized at compile time. Link: https://lore.kernel.org/r/1617108361-6870-1-git-send-email-zhouchuangao@vivo.com Signed-off-by: zhouchuangao Signed-off-by: Martin K. Petersen --- diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c index 85aa5788826bc..1857869e7e8d5 100644 --- a/drivers/message/fusion/mptsas.c +++ b/drivers/message/fusion/mptsas.c @@ -3442,14 +3442,12 @@ mptsas_expander_event_add(MPT_ADAPTER *ioc, __le64 sas_address; port_info = kzalloc(sizeof(struct mptsas_portinfo), GFP_KERNEL); - if (!port_info) - BUG(); + BUG_ON(!port_info); port_info->num_phys = (expander_data->NumPhys) ? expander_data->NumPhys : 1; port_info->phy_info = kcalloc(port_info->num_phys, sizeof(struct mptsas_phyinfo), GFP_KERNEL); - if (!port_info->phy_info) - BUG(); + BUG_ON(!port_info->phy_info); memcpy(&sas_address, &expander_data->SASAddress, sizeof(__le64)); for (i = 0; i < port_info->num_phys; i++) { port_info->phy_info[i].portinfo = port_info;